[flang-commits] [PATCH] D78623: [flang] Semantic checks for SELECT RANK

[sameeran joshi via Phabricator via flang-commits]

sameeranjoshi accepted this revision.
sameeranjoshi marked 3 inline comments as done.
sameeranjoshi added a comment.

In D78623#2022508 <https://reviews.llvm.org/D78623#2022508>, @sameeranjoshi wrote:

> Review comments addressed.


@peterklauslar @timkeith is there still anything which needs to be addressed to merge this PR?



================
Comment at: flang/lib/Semantics/check-select-rank.cpp:115
+
+const SomeExpr *SelectRankConstructChecker::ResolveSelector(
+    const parser::Selector &selector) {
----------------
tskeith wrote:
> I think `GetExpr` is a better name for this function. Nothing is being resolved.
Two same names were causing confusion, hence added a different name `GetExprFromSelector`.


================
Comment at: flang/lib/Semantics/check-select-rank.cpp:114
+                            "Same rank value (%s) not allowed more than once"_err_en_US,
+                            expr->AsFortran())
+                        .Attach(prevloc, "Previous use"_err_en_US);
----------------
tskeith wrote:
> Can you print `*val` instead of fetching and formatting expr?
Updated revision using *val.
The kind value vanishes when using *val. Only the rank value would be displayed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78623/new/

https://reviews.llvm.org/D78623