[flang-commits] [PATCH] D93105: [Flang][openmp][5.0] Add task_reduction clause.

Tue Dec 22 08:24:10 PST 2020

sameeranjoshi added a comment.

In D93105#2464268 <https://reviews.llvm.org/D93105#2464268>, @yhegde wrote:

> In D93105#2461225 <https://reviews.llvm.org/D93105#2461225>, @kiranchandramohan wrote:
>
>> @yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?
>
> Yes. Rt now I am directly getting the list of Designators . Now it will become a level of indirection with the list of OmpObjects. 
> I may be missing something but OpenMP 4.5 and 5.0 Reduction clause restrictions looks very similar , why this one level of indirection required?! Is it because functions names in Reduction clause can come from common blocks ?!

I am not sure if I completely understand your question.
`struct OmpObject` wraps over `std::variant<Designator, /*common block*/ Name> u`, and if you were trying to ask why did we change that from `Designator` to `OmpObject` check comments at https://reviews.llvm.org/D93105#inline-870822.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93105/new/

https://reviews.llvm.org/D93105