[flang-commits] [PATCH] D93105: [Flang][openmp][5.0] Add task_reduction clause.

[Yashaswini Hegde via Phabricator via flang-commits]

yhegde added a comment.

In D93105#2461225 <https://reviews.llvm.org/D93105#2461225>, @kiranchandramohan wrote:

> @yhegde Will the changes in this patch affect your reduction patch (https://reviews.llvm.org/D90697)?

Yes. Rt now I am directly getting the list of Designators . Now it will become a level of indirection with the list of OmpObjects. 
I may be missing something but OpenMP 4.5 and 5.0 Reduction clause restrictions looks very similar , why this one level of indirection required?! Is it because functions names in Reduction clause can come from common blocks ?!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93105/new/

https://reviews.llvm.org/D93105