[flang-commits] [PATCH] D85937: [flang][msvc] Split class declaration and constexpr variable definition. NFC.

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D85937#2219412 <https://reviews.llvm.org/D85937#2219412>, @Meinersbur wrote:

> @klausler I updated the patch before I noticed you accepted the version without the requested change that you defended vigorously. Which version do you want?

That's a mischaracterization of my comments.  I suggested alternatives and tried to weigh their tradeoffs.

If you don't care either way, make this and later workarounds conditional.  But if you have a preference, use your best judgment and follow it, here and on later MSVC workaround patches.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85937/new/

https://reviews.llvm.org/D85937