[flang-commits] [PATCH] D84334: [flang] Version information in flang/f18

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D84334#2213327 <https://reviews.llvm.org/D84334#2213327>, @richard.barton.arm wrote:

> @coti - I've had another look and I think your new test is stumbling across an existing bug. If you play around with the existing `__F18*` macros, you can see that they are not being applied correctly in the code:
>
>   ricbar01 at hw-a21-17:~/ossf18/llvm-project/flang$ cat test.f90
>   PROGRAM FOO
>     integer i = __F18__
>   end program foo
>   ricbar01 at hw-a21-17:~/ossf18/llvm-project/flang$ ../../build/bin/flang -DFOO=bar test.f90 -E
>   program foo
>   integer i = __f18__
>   end program foo
>
> So I don't think there is anything wrong with the code changes or test, but perhaps another bug to fix in the preprocessor itself. Its the end of the day for me now, but I'll look again tomorrow.
>
> I have not looked at the out of tree build issues. Have you tried isuru's suggestion?

I think I remember fixing something in that area with predefined (command-line -D flag) options; I'll see whether it still needs to be pushed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334