[flang-commits] [PATCH] D85355: [flang][msvc] Do not use gcc/clang command line options for msvc.

[Tim Keith via Phabricator via flang-commits]

tskeith added subscribers: schweitz, tskeith.
tskeith added a comment.

In D85355#2200014 <https://reviews.llvm.org/D85355#2200014>, @klausler wrote:

> In D85355#2199935 <https://reviews.llvm.org/D85355#2199935>, @Meinersbur wrote:
>
>> Some developers build with -Werror and removing them entirely would break their build since these components seem to have warnings in them. There were lengthy discussions about the point of -Werror already (see D78306 <https://reviews.llvm.org/D78306>, D81695 <https://reviews.llvm.org/D81695>), which this patch is not about, just making it msvc-compatible.
>
> We always built with -Werror before we contributed f18 to llvm, and still do so in-house for the discipline it enforces, but gcc's warning about unused function arguments produced false messages in the case of templatized code (esp. with constexpr) that are not practical to work around, so that warning is explicitly disabled.

I removed the setting of `CMAKE_CXX_FLAGS` and couldn't find a version of GCC that failed. Can we just get rid of this? @schweitz?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85355/new/

https://reviews.llvm.org/D85355