[flang-commits] [PATCH] D84334: Version information in flang/f18

Wed Aug 5 00:16:55 PDT 2020

richard.barton.arm accepted this revision.
richard.barton.arm added a comment.
This revision is now accepted and ready to land.

Thanks for adding the tests. IMO, the regex approach in the test is just fine.

I have made a couple of small suggestions and am happy to approve on the basis that those are addressed.

I think one of @AlexisPerry or @sscalpone should also approve before you push.

Thanks for the work on this.

================
Comment at: flang/test/Preprocessing/macros.F90:1
+! Check that the macros that give the verion number are set properly
+
----------------
Suggest this be renamed "compiler_defined_macros" or "predefined_macros" to separate it from a general test on user-defined macros.

================
Comment at: flang/tools/f18/f18.cpp:418
+      "__flang_patchlevel__", __FLANG_PATCHLEVEL__);
+  options.predefinitions.emplace_back("__flang_version__", __FLANG_VERSION__);
 #if __x86_64__
----------------
Given the bug that you have found with __flang_version__, I suggest we don't define the external macro in this patch, given that it won't be usable and it's essentially exposing the bug that wasn't there before.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334