[flang-commits] [PATCH] D82931: [flang][OpenMP] Enhance parser support for atomic construct to OpenMP 5.0

[Kiran Chandramohan via Phabricator via flang-commits]

kiranchandramohan added a comment.

Looks OK to me.

Two questions inline.  Please add a few more tests covering all new memory-orders.



================
Comment at: flang/include/flang/Parser/parse-tree.h:3644
+  UNION_CLASS_BOILERPLATE(OmpAtomicMemoryOrderClause);
+  CharBlock source;
+  std::variant<OmpMemoryOrderClause, OmpHintExpr> u;
----------------
Is the source field used by the parser? I didn't see a sourced parser for OmpAtomicMemoryOrderClause.


================
Comment at: flang/test/Semantics/omp-atomic.f90:14
 
+  !$omp atomic read acquire hint(1)
+  a = b
----------------
Can you use the omp_lib module and add tests for hints with the enum/kind value? like HINT(OMP_LOCK_HINT_CONTENDED)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82931/new/

https://reviews.llvm.org/D82931