[flang-commits] [PATCH] D84334: Version information in flang/f18

[Peter Klausler via Phabricator via flang-commits]

klausler added a comment.

In D84334#2192984 <https://reviews.llvm.org/D84334#2192984>, @richard.barton.arm wrote:

> Looking good. Please can you add some tests?
>
> - For --version, there already is one for the version screen in flang/test/Driver that could be updated to capture the version number also and run multiple times to test the synonyms.
>   - Testing {{\-v}} when it means verbose is hard so suggest not doing that. We need {{-###}} really to test the driver more, which is outside the scope of your change.
> - For the macros, I think the flang/test/Preprocessing" directory would be the best place but that directory is full of non-tests (which we need to delete really) so we can't add a real test there at the moment. Perhaps add a new test to flang/test/Driver for now that runs flang with -E and checks the substitutions work.

Please don't delete the tests in flang/test/Preprocessing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D84334/new/

https://reviews.llvm.org/D84334