[clangd-dev] Heads-up: change in test directory structure will conflict with your patches

[Eric Liu via clangd-dev]

> check-clang-tools no longer runs clangd tests.
I think the assumption with `check-clang-tools` has been that it will run
all tests in clang-tools-extra/. I think it's also a common way to verify
changes in clang/ (e.g. tooling) or shared libraries like clang-tidy do not
break things in extra. If we exclude clangd tests from check-clang-tools,
we might still want to provide an alternative (trivial) way for folks to
verify that their changes (in tooling etc) do not break clangd.
Unfortunately, `check-all` runs all llvm tests and is too slow.

On Mon, Apr 29, 2019 at 11:35 PM Sam McCall via clangd-dev <
clangd-dev at lists.llvm.org> wrote:

> Oops, right.
> check-clangd is the way to run clangd tests, it works as before.
> check-clang-tools no longer runs clangd tests.
> check-all runs clangd tests if clang-tools-extra is enabled, as before.
> (Build bots use this method, so should be unaffected)
>
> Also, apologies for butchering the XPC rules, thanks Jan for cleaning up
> my mess!
>
> On Tue, Apr 30, 2019, 04:32 Marc-Andre Laperle <malaperle at gmail.com>
> wrote:
>
>> Does this change anything to how the tests need to be executed? i.e.
>> check-clangd, etc?
>> Thanks!
>>
>> On Apr 29, 2019, at 3:23 AM, Sam McCall via clangd-dev <
>> clangd-dev at lists.llvm.org> wrote:
>>
>> I'm planning to land a patch that makes the clangd directory structure
>> more self-contained.
>>
>> Before:
>>   clang-tools-extra/clangd
>>   clang-tools-extra/test/clangd
>>   clang-tools-extra/unittests/clangd
>>
>> After:
>>   clang-tools-extra/clangd
>>   clang-tools-extra/clangd/test
>>   clang-tools-extra/clangd/unittests
>>
>> Most people I've talked to agree this is... less annoying.
>> But it will temporarily be more annoying, because this will touch every
>> test file and conflict with all your patches. Sorry :-(
>>
>> https://reviews.llvm.org/D61187
>> _______________________________________________
>> clangd-dev mailing list
>> clangd-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev
>>
>>
>> _______________________________________________
> clangd-dev mailing list
> clangd-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/clangd-dev/attachments/20190429/6253c28f/attachment.html>