[clangd-dev] Heads-up: change in test directory structure will conflict with your patches

Sam McCall via clangd-dev clangd-dev at lists.llvm.org
Mon Apr 29 23:34:49 PDT 2019

Oops, right.
check-clangd is the way to run clangd tests, it works as before.
check-clang-tools no longer runs clangd tests.
check-all runs clangd tests if clang-tools-extra is enabled, as before.
(Build bots use this method, so should be unaffected)

Also, apologies for butchering the XPC rules, thanks Jan for cleaning up my

On Tue, Apr 30, 2019, 04:32 Marc-Andre Laperle <malaperle at gmail.com> wrote:

> Does this change anything to how the tests need to be executed? i.e.
> check-clangd, etc?
> Thanks!
> On Apr 29, 2019, at 3:23 AM, Sam McCall via clangd-dev <
> clangd-dev at lists.llvm.org> wrote:
> I'm planning to land a patch that makes the clangd directory structure
> more self-contained.
> Before:
>   clang-tools-extra/clangd
>   clang-tools-extra/test/clangd
>   clang-tools-extra/unittests/clangd
> After:
>   clang-tools-extra/clangd
>   clang-tools-extra/clangd/test
>   clang-tools-extra/clangd/unittests
> Most people I've talked to agree this is... less annoying.
> But it will temporarily be more annoying, because this will touch every
> test file and conflict with all your patches. Sorry :-(
> https://reviews.llvm.org/D61187
> _______________________________________________
> clangd-dev mailing list
> clangd-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/clangd-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/clangd-dev/attachments/20190430/02e73973/attachment.html>

More information about the clangd-dev mailing list