[clangd-dev] Changing format of clangd_fixes diagnostic extension

Sam McCall via clangd-dev clangd-dev at lists.llvm.org
Fri Oct 12 11:10:48 PDT 2018

(with the right list this time)

On Fri, Oct 12, 2018, 19:16 Sam McCall <sammccall at google.com> wrote:

> Hey Alex,
> I'm trying to simplify our diagnostic/codeAction LSP code a bit in
> preparation for enabling new LSP features. (Diagnostic.relatedInformation,
> and new CodeAction structure with inline edits)
> We have an extension clangd_fixes on Diagnostic to include the fixes
> inline in our own (undocumented?) format.
> I'd like to change the type to CodeAction[] to match what we'll send from
> textDocument/codeAction on that diagnostic.
> While there, I'd like to rename clangd_fixes to codeActions as this seems
> like something we can standardize.
> Any concerns for your use of the extension? Good/bad time to land such a
> change?
> Cheers, Sam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/clangd-dev/attachments/20181012/7bd33a0b/attachment-0001.html>

More information about the clangd-dev mailing list