<div dir="auto">(with the right list this time)</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Oct 12, 2018, 19:16 Sam McCall <<a href="mailto:sammccall@google.com">sammccall@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto">Hey Alex,<div dir="auto"><br></div><div dir="auto">I'm trying to simplify our diagnostic/codeAction LSP code a bit in preparation for enabling new LSP features. (Diagnostic.relatedInformation, and new CodeAction structure with inline edits)</div><div dir="auto"><br></div><div dir="auto">We have an extension clangd_fixes on Diagnostic to include the fixes inline in our own (undocumented?) format.</div><div dir="auto"><br></div><div dir="auto">I'd like to change the type to CodeAction[] to match what we'll send from textDocument/codeAction on that diagnostic.</div><div dir="auto">While there, I'd like to rename clangd_fixes to codeActions as this seems like something we can standardize.</div><div dir="auto"><br></div><div dir="auto">Any concerns for your use of the extension? Good/bad time to land such a change?</div><div dir="auto"><br></div><div dir="auto">Cheers, Sam</div></div>
</blockquote></div>