[cfe-dev] How long does it usually take for a patch to be reviewed?

[Johannes Doerfert via cfe-dev]

FTR, the patch is https://reviews.llvm.org/D87962 titled:

  [clang] Change the multi-character character constants from extension 
to implementation-defined.

As Artem said the issue here is probably that a single reviewer is not 
enough and patches can slip through the cracks.
More reviewers, and pings (which generate emails on the appropriate 
list) can help. To find reviewers it's often good to
blame the lines you modified or lines around it. Unfortunately, the main 
changes in the lexer were last touched a decade
ago by Chris, unclear if that is of much help. Eli added the lines in 
p1.cpp also a decade ago, Jordan Rose the FixIt lines.



On 9/28/20 1:42 AM, Artem Dergachev via cfe-dev wrote:
> You can "ping" the reviewers (by saying "ping" in comments) every now 
> and then. You can't expect an immediate reaction but pinging every 1-2 
> weeks is considered to be polite. Consider bringing in more reviewers. 
> Sometimes you may also make reviewing your patch easier by providing a 
> better summary, adding comments to the code, or generally explaining 
> why do you believe that your patch is the right solution to the 
> problem it's trying to solve.
>
> On 9/27/20 11:25 PM, Chuyang Chen via cfe-dev wrote:
>>
>> I submitted a patch to Phabricator and issued a review request 10 
>> days ago but it hasn’t been reviewed until now.
>>
>> Chuyang Chen
>> MSc Student
>> At Department of Computer Science and Technology, Nanjing University
>>
>>
>> _______________________________________________
>> cfe-dev mailing list
>> cfe-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev