[cfe-dev] [llvm-dev] Phabricator -> GitHub PRs?

[Renato Golin via cfe-dev]

On Sat, 12 Sep 2020 at 03:34, Fangrui Song <maskray at google.com> wrote:

> The typo and `added tests` messages should probably not be there. The
> circt commit demonstrates the exact same problem:
> https://github.com/llvm/circt/commit/9ab7d667f9ad5de06c7986a71ad5e07e19cd55e7


Right. The "have meaningful commit messages" requirement would encompass
that, too. People should always be careful with the commit messages,
regardless of how they're created.

It's already common for reviewers to give hints to people how they should
organise their patches and commit messages, especially if they seem new to
LLVM. It's safe to assume this will continue.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20200912/737bc020/attachment.html>