<div dir="ltr"><div dir="ltr">On Sat, 12 Sep 2020 at 03:34, Fangrui Song <<a href="mailto:maskray@google.com">maskray@google.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The typo and `added tests` messages should probably not be there. The circt commit demonstrates the exact same problem: <a href="https://github.com/llvm/circt/commit/9ab7d667f9ad5de06c7986a71ad5e07e19cd55e7" rel="noreferrer" target="_blank">https://github.com/llvm/circt/commit/9ab7d667f9ad5de06c7986a71ad5e07e19cd55e7</a></blockquote><div><br></div><div>Right. The "have meaningful commit messages" requirement would encompass that, too. People should always be careful with the commit messages, regardless of how they're created.</div><div><br></div><div>It's already common for reviewers to give hints to people how they should organise their patches and commit messages, especially if they seem new to LLVM. It's safe to assume this will continue.</div></div></div>