[cfe-dev] The name of clang/lib/Tooling/Refactoring

[Nico Weber via cfe-dev]

On Fri, May 24, 2019 at 4:34 AM Ilya Biryukov <ibiryukov at google.com> wrote:

> While I personally like consistent naming myself, I'd prefer to be
> conservative with this one and avoid changing something that is not broken
> for other reasons and was like this for years.
>

I find this kind of argument not very convincing. See e.g. the first 7
slides of
https://www.usenix.org/sites/default/files/conference/protected-files/srecon17americas_slides_reese.pdf

We've renamed many libraries to increase consistency, and we know from
experience it's a pretty safe thing to do.

If we do rename, do folks prefer:

1. Renaming the directory to lib/clang/Tooling/Refactor. Requires updating
all #include lines referring to it, and updating a handful of CMake files.

2. Renaming the library to clangToolingRefactoring. Requires updating all
cmake files adding a dependency to use the new library name.


>
> On Thu, May 23, 2019 at 8:05 PM Yitzhak Mandelbaum <yitzhakm at google.com>
> wrote:
>
>> Agreed that it's a bit confusing. I have no preference on what the final
>> (consistent) name should be.
>>
>> On Thu, May 23, 2019 at 2:04 PM Eric Liu <ioeric at waymo.com> wrote:
>>
>>> +Alex L <arphaman at gmail.com> +Ilya Biryukov <ibiryukov at google.com> +Sam
>>> McCall <sammccall at google.com>
>>>
>>> On Thu, May 23, 2019 at 11:01 AM Nico Weber <thakis at chromium.org> wrote:
>>>
>>>> Hi,
>>>>
>>>> all clang libs are usually in clang/lib/Foo/Bar and are the called
>>>> clangFooBar.
>>>>
>>>> However, lib/Tooling/Refactoring is called clangToolingRefactor without
>>>> the "ing".
>>>>
>>>> Can we make that consistent? Would you prefer if we renamed the
>>>> directory or the library?
>>>>
>>>> (I can do the actual renaming if we agree that it's a good thing to do.)
>>>>
>>>> Nico
>>>>
>>>
>
> --
> Regards,
> Ilya Biryukov
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20190524/77111281/attachment.html>