[cfe-dev] Is it possible to run `git commit --amend` on a patch that's already landed?

[Don Hinton via cfe-dev]

On Wed, May 15, 2019 at 10:21 AM Shoaib Meenai <smeenai at fb.com> wrote:

> You could always revert and recommit with the proper attribution, though I
> think just replying to the list is fine, like David said.
>

I ended up doing a revert/recommit.  Thanks for the suggestion.


>
>
> *From: *cfe-dev <cfe-dev-bounces at lists.llvm.org> on behalf of cfe-dev <
> cfe-dev at lists.llvm.org>
> *Reply-To: *Don Hinton <hintonda at gmail.com>
> *Date: *Wednesday, May 15, 2019 at 10:06 AM
> *To: *David Blaikie <dblaikie at gmail.com>
> *Cc: *cfe-dev <cfe-dev at lists.llvm.org>
> *Subject: *Re: [cfe-dev] Is it possible to run `git commit --amend` on a
> patch that's already landed?
>
>
>
> Thanks David, will do.
>
>
>
> Thought arc would add it automatically, but that isn't the case.  Feel bad
> about not giving Torbjörn due credit.
>
>
>
>
>
> On Wed, May 15, 2019 at 10:03 AM David Blaikie <dblaikie at gmail.com> wrote:
>
> I think there are some ways to ammend history in emergencies (if
> confidential data has ended up in a commit, etc) - but generally not.
>
> Emailing the mailing list in reply to the auto-generated commit mail to
> add any extra context is generally the right thing to do in this situation.
>
>
>
> On Wed, May 15, 2019 at 10:02 AM Don Hinton via cfe-dev <
> cfe-dev at lists.llvm.org> wrote:
>
> Unfortunately, I left out a "Patch by.." line in the last commit, and
> would like to add it.
>
>
>
> I can do it locally, but can I `git llvm push` it?
>
>
>
> thanks in advance...
>
> don
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
> <https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_cfe-2Ddev&d=DwMFaQ&c=5VD0RTtNlTh3ycd41b3MUw&r=o3kDXzdBUE3ljQXKeTWOMw&m=GbZUBSuVq2EOwnwuZwaOPkSFxR7O2YlTzHERT8bdv5s&s=EPqxq6gtIGlUAqBGLHUFJNs8hWss00bpp0aiNO-_4cw&e=>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20190515/65473f31/attachment.html>