[cfe-dev] [RFC] Add SYCL programming model support.

[Bader, Alexey via cfe-dev]

Hi Dave,

Thanks for your comments.
We definitely will integrate address spaces support required for SYCL into ToT. The code currently uploaded to the GitHub is our first approach to implement SYCL address spaces inference rules, but we found that it is not robust and difficult to maintain. We are working on alternative implementation emitting "raw" pointers (i.e. w/o specified address space) in "generic" address space and later re-using existing LLVM pass to inference address space.
This approach should be aligned with existing implementation of address spaces for OpenCL C++.

Thanks,
Alexey

-----Original Message-----
From: David Airlie [mailto:airlied at redhat.com] 
Sent: Monday, January 28, 2019 9:45 PM
To: Bader, Alexey <alexey.bader at intel.com>
Cc: cfe-dev (cfe-dev at lists.llvm.org) <cfe-dev at lists.llvm.org>
Subject: Re: [cfe-dev] [RFC] Add SYCL programming model support.

On Sat, Jan 26, 2019 at 6:11 AM Bader, Alexey via cfe-dev <cfe-dev at lists.llvm.org> wrote:
>
> Hi,
>
>
>
> A short update: we uploaded SYCL compiler and runtime sources to the GitHub https://github.com/intel/llvm/tree/sycl.
>
>
>
> Thanks to all who provided feedback and expressed interest in this project (mostly off the clang mailing list).
>
> If there are no objections, we are going to start sending patches for review in a week or two.

Hi Alexey,

I've just started looking over this, and first of all great work! I'm not directly the best person yet to review all of this, but I'm starting to look over it and one thing stood out:

There seems to be some interaction or reliance on old address space behaviour,

I don't think (maybe I'm wrong) that upstream will want to accept:
[SYCL] Revert "[OpenCL] Enable address spaces for references in C++"
or at least the OpenCL C++ people need to be talked to.

Is there some more work that could be done in these to avoid the revert?
[SYCL] Implement SYCL address-space rules.
- do we have to use separate sycl address spaces as at all here btw?
or are the opencl ones defined already not sufficient?
[SYCL] Add SYCL-specific address spaces fixer pass.

Dave.

--------------------------------------------------------------------
Joint Stock Company Intel A/O
Registered legal address: Krylatsky Hills Business Park,
17 Krylatskaya Str., Bldg 4, Moscow 121614,
Russian Federation

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.