[cfe-dev] Inlining dllimport functions

[Louis Dionne via cfe-dev]

> On Sep 14, 2018, at 16:15, Hamza Sood <hamza_sood at me.com> wrote:
> 
> I was thinking more in the context of changing Clang.
> 
> Wouldn’t exporting some of those internal symbols get in the way of ABI stability? libc++ goes to great lengths to keep stuff like that out of the dynamic libraries.

Yes — we don’t want to increase the ABI surface of libc++ unless necessary, because everything that is exported needs to stay the same forever.

Louis

> 
> On 14 Sep 2018, at 19:34, Reid Kleckner wrote:
> 
>> On Fri, Sep 14, 2018, 6:51 AM Hamza Sood <hamza_sood at me.com <mailto:hamza_sood at me.com>> wrote:
>> Would it break ABI compatibility if we let Clang inline things like this? What about putting it behind a Clang-specific optimisation flag?
>> 
>> I'm not sure I understand this ABI compatibility concern.
>> 
>> I was suggesting that libc++ should export all of the class methods it needs, so that we can always emit these dllimport methods as available_externally definitions. This would be much simpler than adding new flags.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20180914/c3ea84fe/attachment.html>