<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Sep 14, 2018, at 16:15, Hamza Sood <<a href="mailto:hamza_sood@me.com" class="">hamza_sood@me.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><meta http-equiv="content-type" content="text/html; charset=utf-8" class=""><div dir="auto" class=""><div dir="ltr" class="">I was thinking more in the context of changing Clang.</div><div dir="ltr" class=""><br class=""></div><div dir="ltr" class="">Wouldn’t exporting some of those internal symbols get in the way of ABI stability? libc++ goes to great lengths to keep stuff like that out of the dynamic libraries.</div></div></div></blockquote><div><br class=""></div><div>Yes — we don’t want to increase the ABI surface of libc++ unless necessary, because everything that is exported needs to stay the same forever.</div><div><br class=""></div><div>Louis</div><br class=""><blockquote type="cite" class=""><div class=""><div dir="auto" class=""><div dir="ltr" class=""><br class="">On 14 Sep 2018, at 19:34, Reid Kleckner wrote:<br class=""><br class=""></div><blockquote type="cite" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div class="gmail_quote"><div dir="ltr" class="">On Fri, Sep 14, 2018, 6:51 AM Hamza Sood <<a href="mailto:hamza_sood@me.com" target="_blank" class="">hamza_sood@me.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="auto" class=""><div dir="ltr" class="">Would it break ABI compatibility if we let Clang inline things like this? What about putting it behind a Clang-specific optimisation flag?</div></div></blockquote><div class=""><br class=""></div><div class="">I'm not sure I understand this ABI compatibility concern.</div><div class=""><br class=""></div><div class="">I was suggesting that libc++ should export all of the class methods it needs, so that we can always emit these dllimport methods as available_externally definitions. This would be much simpler than adding new flags.</div><div class=""></div></div></div>
</div></blockquote></div></div></blockquote></div><br class=""></body></html>