[cfe-dev] Incomplete binary distribution windows

[Hans Wennborg via cfe-dev]

On Wed, Aug 8, 2018 at 5:39 PM, Zachary Turner <zturner at google.com> wrote:
> I can theorize that perhaps what breaks is that if you have an old VS
> integration + LLVM installed, then install a new LLVM, the old VS
> integration will not be able to find the new clang-cl.exe.

The old VS integration would also have been uninstalled in that case.

> I don't have a
> good idea on how to address this off the top of my head except perhaps to
> create the msbuild-bin folder but put a DEPRECATED.TXT file in there so
> people will find it.
>
> The other problem though is that the new VS integration only works with >=
> 2017, so if someone can't upgrade for some reason, this would still be a
> problem for them.  Perhaps we could continue copying the main executable
> there for backwards compatibility?

We'd need to keep installing the old integrations also, and I don't
think we want to keep them around. I think the new extension also
supports VS 2015, at least it installs for it but I didn't actually
try the integration there. Supporting 2017 and 2015 is probably
enough.

Let's hear from degski what his reason for needing msbuild-bin/cl.exe was.

Maybe we should just put a bigger note on the download page that the
old integration is gone and people need to get the new one.

>
> On Wed, Aug 8, 2018 at 6:50 AM Hans Wennborg <hans at chromium.org> wrote:
>>
>> As noted on http://llvm.org/builds/ the installer no longer includes
>> the Visual Studio integration, instead a new one can be downloaded
>> from
>> https://marketplace.visualstudio.com/items?itemName=LLVMExtensions.llvm-toolchain
>> and that does not rely on having the "fake" cl.exe executable.
>>
>> Can you share more details on what broke because the installer doesn't
>> include msbuild-bin/cl.exe? This will also apply to the upcoming llvm
>> 7 release, so it would be good to understand if this causes problems.
>>
>> Thanks,
>> Hans
>>
>> On Wed, Aug 8, 2018 at 7:29 AM, degski via cfe-dev
>> <cfe-dev at lists.llvm.org> wrote:
>> > If anyone feels this email does not concern them then please ignore it.
>> >
>> > Both LLVM-8.0.0-r339039-win64.exe and LLVM-7.0.0-rc1-win64.exe do not
>> > create
>> > the folder ..\LLVM\msbuild-bin and a copy of the main executable renamed
>> > to
>> > cl.exe in that folder. Mahem ensues.
>> >
>> > I'm not writing this for my own purpose, I've solved the issue but for
>> > those
>> > after me.
>> >
>> > Have a nice day,
>> >
>> > degski
>> > --
>> > "If something cannot go on forever, it will stop" - Herbert Stein
>> >
>> > _______________________________________________
>> > cfe-dev mailing list
>> > cfe-dev at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>> >