[cfe-dev] [llvm-dev] [RFC] Embedding Bitcode in Object Files

[Steven Wu via cfe-dev]

> On Feb 5, 2016, at 2:14 PM, James Y Knight <jyknight at google.com> wrote:
> 
> On Wed, Feb 3, 2016 at 1:25 PM, Steven Wu via llvm-dev <llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org>> wrote:
> "__LLVM, __cmdline" is used to store the clang command-line options.  There are
> few options that are not reflected in the bitcode that we would like to replay in
> the rebuild. For example, '-O0' option makes us run FastISel during rebuild.
> 
> Without knowing more details of your implementation, I'd be concerned about how this might impact deterministic/reproducible builds.
> 
> Source paths are recorded in a number of places, but you can typically fix that by using -fdebug-prefix-map. But if the entire command-line including the -fdebug-prefix-map argument gets stored in the output too, then you still have a problem.


I don't think we need any path in the command line section. We only record the command-line options that will affect CodeGen. See my example in one of the preview reply:
> $ clang -fembed-bitcode -O0 test.c -c -###
> "clang" "-cc1"  (...lots of options...) "-o" "test.bc" "-x" "c" "test.c"   <--- First stage
> "clang" "-cc1" "-triple" "x86_64-apple-macosx10.11.0" "-emit-obj" "-fembed-bitcode" "-O0" "-disable-llvm-optzns" "-o" "test.o" "-x" "ir" "test.bc"  <--- Second stage
I can't think of any source path that can affect CodeGen. There should not be any paths other than the bitcode input path and binary output path exists in the second stage and they are excluded from the command line section as well. -fdebug-prefix-map is consumed by the front-end and prefixed paths are a part of the debug info in the metadata. You don't need to encode -fdebug-prefix-map in the bitcode section to reproduce the object file with the same debug info. Did that answer your concern?

Thanks

Steven
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20160205/45de3b9e/attachment.html>