[cfe-dev] [ping][patch] Proposal to add new warning -Wdate-time

[Richard Smith]

On Mon, Apr 28, 2014 at 10:06 AM, Prathamesh Kulkarni <
bilbotheelffriend at gmail.com> wrote:

> On Mon, Apr 28, 2014 at 10:28 PM, Philip Reames
> <listmail at philipreames.com> wrote:
> > Mostly to play devil's advocate...
> >
> > What would this warning gain us over simply using grep?  The use of the
> > macro is purely a textual property, there's no real parsing required.
> Although not realistic, the warning won't be issued if __DATE__/__TIME__,
> gets undefined or redefined.


Devil's advocate again: '-D__DATE__=_Pragma("GCC warning(\"foo\")")' or
just '-U__DATE__' ?


> > If we do accept such a warning, having a more general category for
> > reproducibility problems might be a better approach.  Time and Date are
> one
> > example, but there may be others.
>

I don't see that this is an either/or choice. We can add -Wdate-time now
(or whatever we want to call it) and add it to a -Wreproducibility group
later, when we have other things to put in that group.


> > Philip
> >
> >
> > On 04/28/2014 08:44 AM, Prathamesh Kulkarni wrote:
> >>
> >> Hi,
> >>      I am pinging for this patch, which proposes to add new warning
> >> -Wdate-time:
> >>
> >>
> http://clang-developers.42468.n3.nabble.com/proposal-to-add-new-warning-Wdate-time-td4038953.html
> >> I would be grateful if someone would review it for me.
> >>
> >> Thanks and Regards,
> >> Prathamesh
> >> _______________________________________________
> >> cfe-dev mailing list
> >> cfe-dev at cs.uiuc.edu
> >> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
> >
> >
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20140428/ac73f52a/attachment.html>