<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 28, 2014 at 10:06 AM, Prathamesh Kulkarni <span dir="ltr"><<a href="mailto:bilbotheelffriend@gmail.com" target="_blank">bilbotheelffriend@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="">On Mon, Apr 28, 2014 at 10:28 PM, Philip Reames<br>

<<a href="mailto:listmail@philipreames.com">listmail@philipreames.com</a>> wrote:<br>
> Mostly to play devil's advocate...<br>
><br>
> What would this warning gain us over simply using grep?  The use of the<br>
> macro is purely a textual property, there's no real parsing required.<br>
</div>Although not realistic, the warning won't be issued if __DATE__/__TIME__,<br>
gets undefined or redefined.</blockquote><div><br></div><div>Devil's advocate again: '-D__DATE__=_Pragma("GCC warning(\"foo\")")' or just '-U__DATE__' ?</div><div> <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5">
> If we do accept such a warning, having a more general category for<br>
> reproducibility problems might be a better approach.  Time and Date are one<br>
> example, but there may be others.<br>
</div></div></blockquote><div><br></div><div>I don't see that this is an either/or choice. We can add -Wdate-time now (or whatever we want to call it) and add it to a -Wreproducibility group later, when we have other things to put in that group.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">
> Philip<br>
><br>
><br>
> On 04/28/2014 08:44 AM, Prathamesh Kulkarni wrote:<br>
>><br>
>> Hi,<br>
>>      I am pinging for this patch, which proposes to add new warning<br>
>> -Wdate-time:<br>
>><br>
>> <a href="http://clang-developers.42468.n3.nabble.com/proposal-to-add-new-warning-Wdate-time-td4038953.html" target="_blank">http://clang-developers.42468.n3.nabble.com/proposal-to-add-new-warning-Wdate-time-td4038953.html</a><br>

>> I would be grateful if someone would review it for me.<br>
>><br>
>> Thanks and Regards,<br>
>> Prathamesh<br>
>> _______________________________________________<br>
>> cfe-dev mailing list<br>
>> <a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
><br>
><br>
_______________________________________________<br>
cfe-dev mailing list<br>
<a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev</a><br>
</div></div></blockquote></div><br></div></div>