[cfe-dev] libcxxabi: consistent "cxxabi.h" include
Yaron Keren
yaron.keren at gmail.com
Wed Nov 20 04:04:03 PST 2013
Most of the files in libcxxabi #include "cxxabi.h" but cxa_exception.hpp
and cxa_unexpected.cpp #include <cxxabi.h>.
This caused a problem building from an outside directory since no matter if
I added the libcxxabi as a system dir or a user dir, one of the usages
would be wrong.
Since cxxabi.h is part of libcxxabi, it should included as "cxxabi.h".
Yaron
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20131120/5b6925f9/attachment.html>
-------------- next part --------------
Index: src/cxa_exception.hpp
===================================================================
--- src/cxa_exception.hpp (revision 194870)
+++ src/cxa_exception.hpp (working copy)
@@ -15,7 +15,7 @@
#define _CXA_EXCEPTION_H
#include <exception> // for std::unexpected_handler and std::terminate_handler
-#include <cxxabi.h>
+#include "cxxabi.h"
#include "unwind.h"
namespace __cxxabiv1 {
Index: src/cxa_unexpected.cpp
===================================================================
--- src/cxa_unexpected.cpp (revision 194870)
+++ src/cxa_unexpected.cpp (working copy)
@@ -8,7 +8,7 @@
//===----------------------------------------------------------------------===//
#include <exception>
-#include <cxxabi.h>
+#include "cxxabi.h"
#include "cxa_exception.hpp"
namespace __cxxabiv1
More information about the cfe-dev
mailing list