[cfe-dev] Adding -add-override functionality to cpp11-migrate tool

[Vane, Edwin]

I don't see any emails from you to cfe-commits on Feb 13. Last email I see is from Feb 4 when the patches were still under review and you were working on some problems. I don't remember ever seeing a reviewer's approval. Could you send the patches again?

From: Philip Dunstan [mailto:phil at philipdunstan.com]
Sent: Tuesday, March 26, 2013 1:51 AM
To: Vane, Edwin
Cc: Dmitri Gribenko; cfe-dev at cs.uiuc.edu; Matthieu Monrocq
Subject: Re: [cfe-dev] Adding -add-override functionality to cpp11-migrate tool

Sorry, I haven't had a chance to chase this up lately. I've been changing jobs and then on holiday for a couple of weeks with limited internet access.

I posted the latest set of patches to cfe-commits on February 13 but I don't think they were ever committed. Do I need to do something in particular to have the patches applied?

thanks.
Phil
--
Philip Dunstan
phil at philipdunstan.com<mailto:phil at philipdunstan.com>
www.philipdunstan.com<http://www.philipdunstan.com>

On Mon, Mar 18, 2013 at 11:50 AM, Vane, Edwin <edwin.vane at intel.com<mailto:edwin.vane at intel.com>> wrote:
Any news on this transform?

From: Philip Dunstan [mailto:phil at philipdunstan.com<mailto:phil at philipdunstan.com>]
Sent: Tuesday, February 05, 2013 2:02 PM
To: Dmitri Gribenko
Cc: cfe-dev at cs.uiuc.edu<mailto:cfe-dev at cs.uiuc.edu>; Matthieu Monrocq; Vane, Edwin
Subject: Re: [cfe-dev] Adding -add-override functionality to cpp11-migrate tool

I've attached patches that include this new test:



Phil
--
Philip Dunstan
phil at philipdunstan.com<mailto:phil at philipdunstan.com>
www.philipdunstan.com<http://www.philipdunstan.com>

On Tue, Feb 5, 2013 at 7:23 PM, Dmitri Gribenko <gribozavr at gmail.com<mailto:gribozavr at gmail.com>> wrote:
On Tue, Feb 5, 2013 at 7:44 PM, Philip Dunstan <phil at philipdunstan.com<mailto:phil at philipdunstan.com>> wrote:
> I haven't modified yet how the insertion point for the override keyword is
> calculated. Dmitri suggested FunctionTypeLoc::getRParenLoc() but I don't
> think that this will work if there is a trailing const keyword or deferred
> return type.
Could you please add a test with a trailing return type anyway?

class A {
public:
  virtual int h();
};

class B {
public:
  auto h() -> int;
};

Dmitri

--
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com<mailto:gribozavr at gmail.com>>*/


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130327/c0cfe360/attachment.html>