[cfe-dev] [compiler-rt] 2 nit Win32 patches

["C. Bergström"]

On 07/17/13 08:58 PM, Richard wrote:
> In article<51E5B6DF.9090302 at pathscale.com>,
>      "C. Bergström"<cbergstrom at pathscale.com>  writes:
>
>> Patch 1 : compiler-rt-hidden.patch - Per recommendation from a Windows
>> dev it's not supported and we should disable it.
> I agree with the other comments; namely:
>
> - __attribute__ is best worked around with a macro that expands into an
>    __attribute__ decoration or nothing if the tool chain doesn't
>    support it.  Conditionalize the expansion by a test on the tool
>    chain.
>
> - Tests for the VC++ tool chain are best done with _MSC_VER and not _WIN32
We're not testing with (MSVC) _MSC_VER - We also want to exclude recent 
MingW64 (since it's broken and what we're testing with)