[cfe-dev] @interface and attributes

[Nico Weber]

On Wed, Apr 3, 2013 at 1:00 AM, John McCall <rjmccall at apple.com> wrote:

> On Apr 2, 2013, at 7:51 PM, Nico Weber <thakis at chromium.org> wrote:
> > it's
> >
> >     class __attribute__((visibility("hidden"))) A {};
> >
> > but
> >
> >     __attribute__((visibility("hidden"))) @interface I @end
> >
> > In the first case, clang emits a nice fixit if the attribute is written
> before the class keyword, while putting the attribute after @interface
> makes clang print an ugly diagnostic.
> >
> > Instead of just making that print a nice fixit too, what do you think
> about allowing attributes for @interfaces after the @interface keyword too?
>
> I see no reason to introduce confusion about where to put attributes in an
> @interface.  It's not like after the @interface is actually a good place to
> put attributes.
>

Ok. The attached patch gives attributes after an objc directive a nicer
diagnostic then. Is this ok?

Nico


>
> John.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130403/25b63f27/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-objc-attrs.patch
Type: application/octet-stream
Size: 4747 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20130403/25b63f27/attachment.obj>