[cfe-dev] Compile errors when building kde-runtime

David Blaikie dblaikie at gmail.com
Tue May 22 14:36:15 PDT 2012


On Tue, May 22, 2012 at 2:24 PM, Jordan Rose <jediknil at belkadan.com> wrote:
> I wish we could have fixits for /both/ cases, like -Wparentheses (add parentheses OR change '=' to '=='). But in this case the only automatic way to do it is to add 'void' to the parameters for the inner object instead of an empty list. (The usual way would probably be to add a parameter name, but we can't suggest a name, can we?)
>
> IIRC fixits for non-fatal warnings like this and -Wparentheses are supposed to put the "silence warning and nothing else" fixit first, so that -fixit won't change the behavior of the program as seen now. But there was discussion about this a while ago, and in this case the variable declaration /is/ more likely...

For what it's worth, -fixit mode only applies fixits on the warning
itself. Fixits on notes are never automatically applied (as far as I
know/understand) so that's where semantic-changing fixits can be
found, in any order.

Very few warnings have fixits on them directly for this reason.

- David

>
> Jordy
>
> On May 22, 2012, at 15:48, Nikola Smiljanic wrote:
>
>> How about something like this? It's missing tests and stuff but I hope it's in the right direction. Comments appreciated.
>> <vexing-parse.txt>
>
>
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev




More information about the cfe-dev mailing list