[cfe-dev] MSVC /Za considered harmful

[Sean Silva]

Make sure to update the comment mentioning `/Za` on line 142 of
include/clang/Sema/Ownership.h

--Sean Silva

On Wed, Jun 6, 2012 at 5:47 AM, Francois Pichet <pichet2000 at gmail.com>wrote:

> On Wed, Jun 6, 2012 at 8:17 AM, Nikola Smiljanic <popizdeh at gmail.com>
> wrote:
> > I just removed a couple of lines from CMakeLists that mentioned /Za and
> > projects are now generated without this flag. I did a rebuild using
> Visual
> > Studio 2010 and everything went fine except for CFG.cpp which says:
> >
> > clang\lib\Analysis\CFG.cpp(3203): error C2059: syntax error : '='
> > clang\lib\Analysis\CFG.cpp(3203): error C2143: syntax error : missing ';'
> > before '{'
> > clang\lib\Analysis\CFG.cpp(3204): error C2059: syntax error : '__cdecl'
> >
> > Renaming cdecl variable to decl fixed this, funny.
> >
> > P.S. I know very little about CMake, somebody who knows this stuff should
> > review the patch
> >
>
> I zapped /Za in r158063, cdecl is a reserved keyword in MSVC. (calling
> convention).
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120606/38057b0e/attachment.html>