[cfe-dev] MSVC /Za considered harmful

[Francois Pichet]

On Wed, Jun 6, 2012 at 8:17 AM, Nikola Smiljanic <popizdeh at gmail.com> wrote:
> I just removed a couple of lines from CMakeLists that mentioned /Za and
> projects are now generated without this flag. I did a rebuild using Visual
> Studio 2010 and everything went fine except for CFG.cpp which says:
>
> clang\lib\Analysis\CFG.cpp(3203): error C2059: syntax error : '='
> clang\lib\Analysis\CFG.cpp(3203): error C2143: syntax error : missing ';'
> before '{'
> clang\lib\Analysis\CFG.cpp(3204): error C2059: syntax error : '__cdecl'
>
> Renaming cdecl variable to decl fixed this, funny.
>
> P.S. I know very little about CMake, somebody who knows this stuff should
> review the patch
>

I zapped /Za in r158063, cdecl is a reserved keyword in MSVC. (calling
convention).