[cfe-dev] Expect new Phabricator code review test runs

[Manuel Klimek]

On Sat, Aug 18, 2012 at 11:19 PM, Thiago Farina <tfransosi at gmail.com> wrote:
> On Thu, Aug 16, 2012 at 9:35 AM, Manuel Klimek <klimek at google.com> wrote:
>> On Thu, Aug 16, 2012 at 2:14 PM, Konstantin Tokarev <annulen at yandex.ru> wrote:
>>> 16.08.2012, 11:30, "Manuel Klimek" <klimek at google.com>:
>>>> Hi,
>>>>
>>>> last month we tried Phabricator for code reviews and got some great
>>>> feedback on what's missing. The main issue was that email
>>>> notifications were really bad. We've worked on that, and would like to
>>>> run some more tests by using it and gather some more feedback from the
>>>> community.
>>>
>>> I'm a bit surprised that you being @google.com don't promote Gerrit [1].
>>
>> We want to use what fits the project best. Gerrit is a great tool for
>> a lot of use cases, unfortunately it doesn't fit the clang/llvm
>> workflow well. Of course I looked into Gerrit / Rietveld etc, but all
>> of them have serious downsides
> Could you develop on those downsides?

Yes. There are two questions though: what's the effort, and would
upstream gerrit accept patches that for example enable a post-review
subversion browser for post-commit reviews (I use phab to browse
revisions now because it's better than the websvn stuff). Adding all
that to gerrit would seem very expensive - if you want to try
implementing this & set up a gerrit instance that you think would work
for clang/llvm, feel free to do so.

>> that seem a lot harder to fix.
> If it scales for the size of chromium/ code base why it wouldn't fit for clang?

It's not a problem with scale. In fact, scale is the least of the
problems for clang/llvm code reviews.

> So yes, I'm prompting rietveld/codereview.chromium.org as I've been
> working with it for 3 years and I have been very happy with it. It
> works PRETTY WELL!

Yes, it might have worked pretty well for you. Stock phab without any
changes worked "pretty well" for me, too, but the community jumped at
it when we first tried it out. People are different.

Cheers,
/Manuel