[cfe-dev] Expect new Phabricator code review test runs

Thiago Farina tfransosi at gmail.com
Sat Aug 18 14:19:24 PDT 2012


On Thu, Aug 16, 2012 at 9:35 AM, Manuel Klimek <klimek at google.com> wrote:
> On Thu, Aug 16, 2012 at 2:14 PM, Konstantin Tokarev <annulen at yandex.ru> wrote:
>> 16.08.2012, 11:30, "Manuel Klimek" <klimek at google.com>:
>>> Hi,
>>>
>>> last month we tried Phabricator for code reviews and got some great
>>> feedback on what's missing. The main issue was that email
>>> notifications were really bad. We've worked on that, and would like to
>>> run some more tests by using it and gather some more feedback from the
>>> community.
>>
>> I'm a bit surprised that you being @google.com don't promote Gerrit [1].
>
> We want to use what fits the project best. Gerrit is a great tool for
> a lot of use cases, unfortunately it doesn't fit the clang/llvm
> workflow well. Of course I looked into Gerrit / Rietveld etc, but all
> of them have serious downsides
Could you develop on those downsides?

> that seem a lot harder to fix.
If it scales for the size of chromium/ code base why it wouldn't fit for clang?

So yes, I'm prompting rietveld/codereview.chromium.org as I've been
working with it for 3 years and I have been very happy with it. It
works PRETTY WELL!



More information about the cfe-dev mailing list