[cfe-dev] [cfe-commits] [PATCH] pretty display of unprintable source and correct caret/range/fixup alignment

[Seth Cantrell]

Oh, and the Windows build finished and looks fine.


On Apr 16, 2012, at 11:10 PM, Seth Cantrell wrote:

> It was a line length problem, but one of the other changes eliminated it.
> 
> On Apr 16, 2012, at 11:05 PM, Craig Topper wrote:
> 
>> This style is kind of hard to read as it makes arguments look like local variables at first glance. If it's a line length problem, putting "static void" on a separate line is probably a better choice so that the argument can still line up with the the parenthese.
>> 
>> +static void selectInterestingSourceRegion(
>> +  std::string &SourceLine,
>> +  std::string &CaretLine,
>> +  std::string &FixItInsertionLine,
>> +  unsigned Columns,
>> +  const SourceColumnMap &map) {
>> 
>> -- 
>> ~Craig
> <0003-fix-parameter-formatting.patch>