[cfe-dev] [cfe-commits] [PATCH] pretty display of unprintable source and correct caret/range/fixup alignment

Seth Cantrell seth.cantrell at gmail.com
Mon Apr 16 20:10:14 PDT 2012

It was a line length problem, but one of the other changes eliminated it.

On Apr 16, 2012, at 11:05 PM, Craig Topper wrote:

> This style is kind of hard to read as it makes arguments look like local variables at first glance. If it's a line length problem, putting "static void" on a separate line is probably a better choice so that the argument can still line up with the the parenthese.
> +static void selectInterestingSourceRegion(
> +  std::string &SourceLine,
> +  std::string &CaretLine,
> +  std::string &FixItInsertionLine,
> +  unsigned Columns,
> +  const SourceColumnMap &map) {
> -- 
> ~Craig
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-fix-parameter-formatting.patch
Type: application/octet-stream
Size: 1467 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20120416/6f3728cf/attachment.obj>

More information about the cfe-dev mailing list