[cfe-dev] [PATCH] C++0x unicode string and character literals now with test cases

Eric Christopher echristo at apple.com
Mon Jul 18 13:16:12 PDT 2011


On Jul 18, 2011, at 11:50 AM, Craig Topper wrote:

> Thanks for the review! I'll fix the line lengths tonight. Do you know
> who is more familiar with the code?

Chris or Doug would be the two people most likely to approve it.

Had a couple of thoughts that I figured I'd ask about:

a) the enum for character and string is almost identical, any reason
not to make them identical

b) any reason not to have the string literal creation machinery just
default to ascii and not need the changes in most of the use cases?

-eric



More information about the cfe-dev mailing list