[cfe-dev] [PATCH] C++0x unicode string and character literals now with test cases
Craig Topper
craig.topper at gmail.com
Mon Jul 18 11:50:10 PDT 2011
Thanks for the review! I'll fix the line lengths tonight. Do you know
who is more familiar with the code?
Thanks,
~Craig
On Mon, Jul 18, 2011 at 11:34 AM, Eric Christopher <echristo at apple.com> wrote:
>
> On Jul 17, 2011, at 8:47 PM, Craig Topper wrote:
>
>> Hello,
>>
>> Attached is a new patch that fixes a few bugs in the patch I posted
>> last week. It also converts the multiple bool flags I was using into
>> an enum. I've updated existing char literal and string literal tests
>> and a few others to cover the new types.
>>
>> Hopefully someone can review.
>
> I took a quick look at it and it looks pretty good. You'll want to watch
> long (> 80 character) lines. Someone more familiar with the code will
> have to approve it though.
>
> Thanks!
>
> -eric
>
--
~Craig
More information about the cfe-dev
mailing list