[cfe-dev] [PATCH] plugin problem on Windows

Argyrios Kyrtzidis kyrtzidis at apple.com
Tue Apr 5 15:17:51 PDT 2011


On Apr 5, 2011, at 1:44 PM, John Thompson wrote:

>  
> Argyrios,
>  
> I think we should move away from the llvm::Registry mechanism. How about the exported function returns a PluginASTAction*, we store all PluginASTAction* pointers that the plugins return and iterate over them when invoking plugin actions.
>  
> Sounds good to me.  But if not, at least fix the Registry mechanism by adding the needed accessors, which curiously it doesn't have, which is what I tried to do in my patch.

Well your patch pokes at and exposes, IMO, implementation details of Registry; it doesn't seem the right way to go about it..

>  
> -John
> 
> -- 
> John Thompson
> John.Thompson.JTSoftware at gmail.com
> 
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20110405/a2fe79cd/attachment.html>


More information about the cfe-dev mailing list