[cfe-dev] [patch] properly escape strings in xml output + re-enable utest for ast-print-xml

[Chris Lattner]

Thanks, applied in r103671

On May 11, 2010, at 10:21 AM, Sebastien Binet wrote:

> Excerpts from Chris Lattner's message of 2010-05-11 19:13:42 +0200:
>> 
>> On May 11, 2010, at 10:06 AM, Sebastien Binet wrote:
>> 
>>> Excerpts from Chris Lattner's message of 2010-05-11 19:04:16 +0200:
>>>> ENOPATCH :-)
>>> 
>>> arf !
>> 
>> Is this hunk intended?
>> 
>> +++ lib/Frontend/DeclXML.cpp    (working copy)
>> @@ -49,7 +49,7 @@
>>     addSubNodes(cast<RecordDecl>(RD));
>> 
>>     if (RD->isDefinition()) {
>> -      Doc.addAttribute("num_bases", RD->getNumBases());
>> +      //Doc.addAttribute("num_bases", RD->getNumBases());
> 
> yes (I should indeed have documented it)
> the problem is that by re-using the dumping code for RecordDecl, the
> CXXRecordDecl node is already closed by the time one tries to add this
> new num_bases attribute.
> 
> something better needs to be done here, but fixing the XML generation
> was the priority :)
> 
> cheers,
> sebastien.
> -- 
> #########################################
> # Dr. Sebastien Binet
> # Laboratoire de l'Accelerateur Lineaire
> # Universite Paris-Sud XI
> # Batiment 200
> # 91898 Orsay
> #########################################