[cfe-dev] [PATCH] add unconditional support for @encode block descriptor string

Fariborz Jahanian fjahanian at apple.com
Thu Feb 18 18:00:45 PST 2010

Few comments.
Since hasIntrospection is no longer in use, you need to remove the  
option and all the code controlled by this flag.
Please run your test suite with the change for any regression.
Provide a test case  checking for new stuff being generated.

Our coding conversion is 1) no tab 2) limited to 80 columns (just in  

Don't use {...}. Please remove '{' and '}'

- Fariborz

On Feb 18, 2010, at 5:34 PM, Blaine Garst wrote:

> David Chisnall provided, as an option, an introspection field for  
> blocks (const char *types) in the block literal data structure  
> itself for use by the GNU runtime.
> This was discussed and approved and integrated.
> I am unconditionally adding this field instead to the read-only  
> shared block descriptor data structure instead.  I am  
> unconditionally re-using his BLOCK_HAS_OBJC flag bit.
> Also, I am introducing a second new reserved field for block  
> internal layout, initially set to NULL.
> These need to be discussed in the ABI document and supported in the  
> runtime.  Also, David's conditional support should be removed when  
> he's ready.  I left it in to simplify understanding of the changes  
> and, of course, to support his clients until he transitions his  
> runtime to use the new location of the types field.
> This diff reflects the already committed cleanup from my previous  
> PATCH post today.
> <CodeGen.patch>_______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev

More information about the cfe-dev mailing list