[cfe-dev] AltiVec support with remarks considered

Anton Yartsev anton.yartsev at gmail.com
Tue Apr 13 16:22:13 PDT 2010


On 13.04.2010 5:12, Chris Lattner wrote:
> On Apr 5, 2010, at 8:13 PM, Anton Yartsev wrote:
>
>    
>> Hi all,
>>
>> Attached are the header and the patch giving support for all the predicates and a portion of another AltiVec functions. The test is also attached.
>> 'altivec.h' is now included implicitly when '-faltivec' option is set. Only vital builtins are handled by clang, others are supported via header.
>> Please review.
>>      
> Hi Anton,
>
> I have no opinion or background to decide if this implements the feature properly, but the patch itself looks great to me.
>
> One minor change though: please remove __builtin_altivec_abs_v4sf.  Instead of having the builtin, you can just implement vec_abs with the corresponding expanded code in the header.  Feel free to apply the patch (or resend and I'll apply) with that change.
>
> Thanks!
>
> -Chris
Hi Chris,

here are updated files

-- 
Anton

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: altivec.h
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100414/4e1f61ae/attachment.h>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: altivec.patch
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100414/4e1f61ae/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: builtins-pcc-altivec.c
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20100414/4e1f61ae/attachment.c>


More information about the cfe-dev mailing list