[cfe-dev] CodeCompleteConsumer patch

Douglas Gregor dgregor at apple.com
Tue Sep 29 08:16:06 PDT 2009

On Sep 28, 2009, at 8:38 PM, John Thompson wrote:

> Please find enclosed a patch for fixing the 8 CodeCompletion test  
> failures on Windows.  There must have been some kind of code  
> ordering issue, as in the CodeCompletionString::getAsString() as  
> compiled by VS, the flush was only being done in the  
> raw_string_ostream destructor, which happened after the Result  
> object is copied for the return.  I'm not sure how it worked under  
> gcc.

I have no idea how it worked! Perhaps GCC's iostreams library is  
effectively flushing sooner.

Committed here, thanks!


	- Doug

More information about the cfe-dev mailing list