[cfe-dev] RFC: Clang test runner changes

[Daniel Dunbar]

On Thu, Jul 30, 2009 at 3:48 PM, Eli Friedman<eli.friedman at gmail.com> wrote:
> On Mon, Jul 27, 2009 at 3:32 PM, Daniel Dunbar<daniel at zuster.org> wrote:
>>  - Implement the execution of RUN lines internally to the tool. The
>> format will probably become a bit more strict, instead of "sh" format.
>> The runner can then start to validate the lines, for example to ensure
>> that only certain tools are called (clang-cc, count, not, FileCheck,
>> etc.). The runner can then also implement certain features internally
>> (like grep).
>
> Hmm, actually, there's something seriously screwy with the testrunner
> at the moment: we don't actually support not and count, but tests
> using them still manage to pass.

I'm not sure what you mean by "we don't actually support not and
count". The test runner modifies the PATH of the subprocess to include
LLVM's test/Scripts dir, which is the same as it used to do (although
the mechanism changed a bit).

> I was just experimenting a bit with
> not creating .script files, and somehow reading the commands from
> stdin changes the relevant behavior.  (The other issue with reading
> the commands from stdin is that it appears to trigger some sort of
> thread safety bug, but that isn't really relevant if you're planning
> on rewriting the code.)

I'm not exactly sure what problem you are referring to, but yeah
perhaps not worth worrying about until things change to not using
/bin/sh.

 - Daniel