[cfe-dev] thread class patch to llvm/system for clang distcc server
Chris Lattner
clattner at apple.com
Thu Aug 14 10:43:13 PDT 2008
On Aug 11, 2008, at 3:37 PM, Csaba Hruska wrote:
>
> Here is the newest version.
> The kill is for handling crashes.
How does it handle crashes? I don't understand how that is even
relevant.
-Chris
>
>
> Csaba
>
> 2008/8/11 Chris Lattner <clattner at apple.com>
>
> On Aug 11, 2008, at 2:25 AM, Csaba Hruska wrote:
>
>> Hi!
>> Here is the second version of my patch to support platform
>> independent threading required by clangserver.
>>
>
> This looks pretty reasonable to me, but do you really need
> Thread::kill? Thread killing is a very touchy subject that often
> just doesn't work right in many cases (e.g. dtors in killed threads
> are often not run), it would be better to not depend on it.
>
> Also, should the code in lib/System/Unix/Thread.inc call assert(0)
> or abort since they aren't implemented yet (instead of being empty)?
>
> -Chris
>
> <thread.patch3>_______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20080814/0aae3b8a/attachment.html>
More information about the cfe-dev
mailing list