<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 11, 2008, at 3:37 PM, Csaba Hruska wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br>Here is the newest version.<br>The kill is for handling crashes.</div></blockquote><div><br></div>How does it handle crashes? I don't understand how that is even relevant.</div><div><br></div><div>-Chris</div><div><br><blockquote type="cite"><div dir="ltr"><br><br>Csaba<br><br><div class="gmail_quote">2008/8/11 Chris Lattner <span dir="ltr"><<a href="mailto:clattner@apple.com">clattner@apple.com</a>></span><br> <blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div style=""><div class="Ih2E3d"><br><div><div>On Aug 11, 2008, at 2:25 AM, Csaba Hruska wrote:</div> <br><blockquote type="cite"><div dir="ltr">Hi!<br>Here is the second version of my patch to support platform independent threading required by clangserver.<br><br></div></blockquote><br></div></div><div>This looks pretty reasonable to me, but do you really need Thread::kill? Thread killing is a very touchy subject that often just doesn't work right in many cases (e.g. dtors in killed threads are often not run), it would be better to not depend on it.</div> <div><br></div><div>Also, should the code in <span style="font-family: Monaco; font-size: 10px;">lib/System/Unix/Thread.inc call assert(0) or abort since they aren't implemented yet (instead of being empty)?</span></div> <div><br></div><font color="#888888"><div>-Chris</div></font></div></blockquote></div><br></div> <span><thread.patch3></span>_______________________________________________<br>cfe-dev mailing list<br><a href="mailto:cfe-dev@cs.uiuc.edu">cfe-dev@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev<br></blockquote></div><br></body></html>