[cfe-dev] thread class patch to llvm/system for clang distcc server

[Chris Lattner]

On Aug 11, 2008, at 2:25 AM, Csaba Hruska wrote:

> Hi!
> Here is the second version of my patch to support platform  
> independent threading required by clangserver.
>

This looks pretty reasonable to me, but do you really need  
Thread::kill?  Thread killing is a very touchy subject that often just  
doesn't work right in many cases (e.g. dtors in killed threads are  
often not run), it would be better to not depend on it.

Also, should the code in lib/System/Unix/Thread.inc call assert(0) or  
abort since they aren't implemented yet (instead of being empty)?

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-dev/attachments/20080811/17ab1c18/attachment.html>