<html><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 11, 2008, at 2:25 AM, Csaba Hruska wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Hi!<br>Here is the second version of my patch to support platform independent threading required by clangserver.<br><br></div></blockquote><br></div><div>This looks pretty reasonable to me, but do you really need Thread::kill? Thread killing is a very touchy subject that often just doesn't work right in many cases (e.g. dtors in killed threads are often not run), it would be better to not depend on it.</div><div><br></div><div>Also, should the code in <span class="Apple-style-span" style="font-family: Monaco; font-size: 10px; ">lib/System/Unix/Thread.inc call assert(0) or abort since they aren't implemented yet (instead of being empty)?</span></div><div><br></div><div>-Chris</div></body></html>