[clang] [Clang][AMDGPU] Name the builtin in required target feature diagnostics (PR #218358)

Rana Pratap Reddy via cfe-commits cfe-commits at lists.llvm.org
Sun Nov 15 22:19:00 PST 2026


================
@@ -34,6 +34,23 @@ namespace clang {
 
 SemaAMDGPU::SemaAMDGPU(Sema &S) : SemaBase(S) {}
 
+bool SemaAMDGPU::checkBuiltinRequiredTargetFeatures(
+    unsigned BuiltinID, CallExpr *TheCall,
+    const llvm::StringMap<bool> &CallerFeatureMap) {
+  ASTContext &Ctx = getASTContext();
+  StringRef FeatureList(Ctx.BuiltinInfo.getRequiredFeatures(BuiltinID));
+  if (Builtin::evaluateRequiredTargetFeatures(FeatureList, CallerFeatureMap))
+    return false;
+
+  const FunctionDecl *BuiltinDecl = TheCall->getDirectCallee();
+  Diag(TheCall->getBeginLoc(), diag::err_builtin_needs_feature)
+      << (BuiltinDecl ? BuiltinDecl->getDeclName()
+                      : DeclarationName(&Ctx.Idents.get(
----------------
ranapratap55 wrote:

`BuiltinID` is not always reliable. For aux-target builtins,`Sema::CheckBuiltinFunctionCall` passes `getAuxBuiltinID(BuiltinID)`, and `Builtin::Context` resolves that ID in the primary target's builtin table, so `getName`/`getRequiredFeatures` describe an unrelated x86 builtin.

https://github.com/llvm/llvm-project/pull/218358


More information about the cfe-commits mailing list