[clang] [llvm] [clang-linker-wrapper][SYCL] Support relocatable linking (PR #242098)

Yury Plyakhin via cfe-commits cfe-commits at lists.llvm.org
Fri Nov 13 15:49:47 PST 2026


================
@@ -826,8 +826,11 @@ wrapDeviceImages(ArrayRef<std::unique_ptr<MemoryBuffer>> Buffers,
   case OFK_SYCL: {
     // TODO: fill these options once the Driver supports them.
     offloading::SYCLJITOptions Options;
-    if (Error Err =
-            offloading::wrapSYCLBinaries(M, BuffersToWrap.front(), Options))
+    // -r removes .llvm.offloading from the -o file, but the registration code
+    // refers to the device image, so put the image in .sycl_fatbin instead.
----------------
YuriPlyakhin wrote:

nit
I would remove this comment. it seems unnecessary. I would keep the proper comment at wrapSYCLBinaries declaration. that way behavior is documented in a single place in the code.

https://github.com/llvm/llvm-project/pull/242098


More information about the cfe-commits mailing list